[CenterIM-devel] Patch IRC found

[Jayjay]

Hi all,

I just found a patch at the old centericq package bug tracker system of 
Debian [1]. Do you think this patch is useful? I don't use IRC myself, 
please review the code and let us know.

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=429518

Cheers,
Jayjay


- Copied part -

*From:* "Dmitry E. Oboukhov" <dimka at ...
*To:* Debian Bug Tracking System
*Subject:* centericq: Some IRC messages conversion error.
*Date:* Mon, 18 Jun 2007 18:43:53 +0400

Package: centericq
Version: 4.21.0-19
Severity: normal
Tags: patch

In case when user's coding and irc's coding are not match each other messages on user's logout and channels' subjects are converted incorrectly. This patch will cure that defect. 



The included patch:
-----------------------------------------------------
diff -rNu src/hooks/irchook.cc src/hooks/irchook.cc
--- src/hooks/irchook.cc    2004-12-20 03:54:02.000000000 +0300
+++ src/hooks/irchook.cc    2007-06-18 16:30:09.000000000 +0400
@@ -1395,6 +1395,7 @@
 
     if(conf.getourid(irc).nickname != who) {
     string text;
+    string text2;
     char buf[512];
 
     sprintf(buf, _("%s has left"), who); text = buf;
@@ -1402,7 +1403,8 @@
     if(reason)
     if(strlen(reason)) {
         if(strlen(reason) > 450) reason[450] = 0;
-        sprintf(buf, _("reason: %s"), reason);
+            text2 = irhook.rushtmlconv( "wk", reason );
+        sprintf(buf, _("reason: %s"), text2.c_str() );
         text += (string) "; " + buf + ".";
     }
 
@@ -1452,7 +1454,8 @@
 
     string text;
     char buf[1024];
-    sprintf(buf, _("Channel topic now is: %s"), topic);
+    text = irhook.rushtmlconv( "wk", topic );
+    sprintf(buf, _("Channel topic now is: %s"), text.c_str());
     text = buf;
 
     if(author)